This revision was automatically updated to reflect the committed changes.
Closed by commit rG31ea714e9a94: Add rpath to liblldb so vendors can ship their
own python framework (or others) (authored by António Afonso
).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
smeenai accepted this revision.
smeenai added a comment.
LGTM
Comment at: lldb/cmake/modules/LLDBFramework.cmake:125
+# Add an rpath pointing to the directory where LLDB.framework is installed.
+# This allows frameworks (relying on @rpath) to be installed in the same
folder an
aadsm updated this revision to Diff 228765.
aadsm edited the summary of this revision.
aadsm added a comment.
Clarify the point of the install_path
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69931/new/
https://reviews.llvm.org/D69931
Files:
l
smeenai added inline comments.
Comment at: lldb/cmake/modules/LLDBFramework.cmake:124
+
+# Add an rpath pointing to the directory where LLDB.framework is installed.
+set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH
smeenai wrote:
> You may wanna add the