jankratochvil added a comment.
Reverted the refactorization by:
https://github.com/llvm/llvm-project/commit/6dd0163502ff8c48195643b2b08a123c495743a0
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70646/new/
https://reviews.llvm.org/D70646
jankratochvil marked an inline comment as done.
jankratochvil added a comment.
This commit broke: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/7400/
Going to revert the return value refactorization.
That `DWARFDebugInfoEntry::GetDWARFDeclContext()` refactorization for return
value was
jankratochvil marked 2 inline comments as done.
jankratochvil added a comment.
Checked in, thanks for the review.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3987-4008
+ DWARFASTParser *dwarf_ast = GetDWARFParser(*die.GetCU());
+ if (dwarf_ast)
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rG789beeeca3cd: [lldb] Move non-DWARF code: DWARFUnit -
SymbolFileDWARF (authored by jankratochvil).
Changed prior to commit:
https://reviews.llvm.org/D70646?vs=241634=241715#toc
Repository:
rG LLVM
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks great, modulo the inline comment.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3987-4008
+ DWARFASTParser *dwarf_ast =
jankratochvil marked 2 inline comments as done.
jankratochvil added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4011
+void SymbolFileDWARF::GetDWARFDeclContext(const DWARFDIE ,
+ DWARFDeclContext
jankratochvil updated this revision to Diff 241634.
jankratochvil marked an inline comment as done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70646/new/
https://reviews.llvm.org/D70646
Files:
labath added a reviewer: JDevlieghere.
labath added a comment.
This moves a lot of lldb-specific stuff out of low-level dwarf code, and as
such, I think this is a great step towards the parser unification.
I'd just like to squeeze one interface tweak to function we are moving around,
but
jankratochvil updated this revision to Diff 239571.
jankratochvil retitled this revision from "RFC 2/3: Move non-DWARF code:
`DWARFUnit` -> `SymbolFileDWARF`" to "Move non-DWARF code: `DWARFUnit` ->
`SymbolFileDWARF`".
jankratochvil edited the summary of this revision.
Repository:
rG LLVM
