This revision was automatically updated to reflect the committed changes.
Closed by commit rG773b849c10a6: [lldb/DWARF] Switch to llvm location list
parser (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D71003?vs=232319&id=232809#toc
Repository:
rG LLVM Github Monore
clayborg accepted this revision.
clayborg added a comment.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71003/new/
https://reviews.llvm.org/D71003
___
lldb-commits mailing list
lldb-commits@lists
labath added inline comments.
Comment at: lldb/include/lldb/Expression/DWARFExpression.h:260
- bool GetLocation(lldb::addr_t func_load_addr, lldb::addr_t pc,
- lldb::offset_t &offset, lldb::offset_t &len);
+ void RelocateLowHighPC(lldb::addr_t load_function_
labath updated this revision to Diff 232319.
labath marked 10 inline comments as done.
labath added a comment.
- "inline" RelocateLowHighPC
- add some comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71003/new/
https://reviews.llvm.org/D71003
aprantl added a comment.
Nice!
Comment at: lldb/source/Expression/DWARFExpression.cpp:57
+
+static std::unique_ptr
+GetLocationTable(DWARFExpression::LocationListFormat format, const
DataExtractor &data) {
Doxygen comment?
Comment at: lldb/s
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Expression/DWARFExpression.h:260
- bool GetLocation(lldb::addr_t func_load_addr, lldb::addr_t pc,
- lldb::offset_t &offset, lldb::offset_t &len);
+ void RelocateLowHighPC(lldb::addr_t load_fun
dblaikie added inline comments.
Comment at: lldb/source/Expression/DWARFExpression.cpp:2829
+if (!loc)
+ LLDB_LOG_ERROR(log, loc.takeError(), "{0}");
+if (loc->Range) {
labath wrote:
> labath wrote:
> > dblaikie wrote:
> > > Does LLDB_LOG_ERROR stop
labath added inline comments.
Comment at: lldb/source/Expression/DWARFExpression.cpp:2829
+if (!loc)
+ LLDB_LOG_ERROR(log, loc.takeError(), "{0}");
+if (loc->Range) {
labath wrote:
> dblaikie wrote:
> > Does LLDB_LOG_ERROR stop the program? If not, t
labath updated this revision to Diff 232106.
labath marked 4 inline comments as done.
labath added a comment.
Feedback @dblaikie.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71003/new/
https://reviews.llvm.org/D71003
Files:
lldb/include/lldb/E
labath marked an inline comment as done.
labath added inline comments.
Comment at: lldb/source/Expression/DWARFExpression.cpp:2829
+if (!loc)
+ LLDB_LOG_ERROR(log, loc.takeError(), "{0}");
+if (loc->Range) {
dblaikie wrote:
> Does LLDB_LOG_ERROR stop
dblaikie added inline comments.
Comment at: lldb/source/Expression/DWARFExpression.cpp:72
+ }
+ llvm_unreachable("Fully covered switch!");
+}
I think usually the unreachable comment that's used in this sort of case is
"Invalid LocationListFormat!" or similar,
labath created this revision.
labath added reviewers: JDevlieghere, aprantl, clayborg.
Herald added a project: LLDB.
labath added a parent revision: D70532: [lldb] Improve/fix base address
selection in location lists.
This patch deletes the lldb location list parser and teaches the
DWARFExpressio
12 matches
Mail list logo
