[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

labath added a comment. In D72597#1819185 , @SouraVX wrote: > In D72597#1819164 , @labath wrote: > > > I have a high-level question/comment. Are you planning to implement > > debug_macro reading in llvm-dwarfdump?

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX added a comment. In D72597#1819164 , @labath wrote: > I have a high-level question/comment. Are you planning to implement > debug_macro reading in llvm-dwarfdump? Even if you aren't, I am expecting > that you will be asked to do that as a part

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX marked 4 inline comments as done. SouraVX added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp:62 +const DWARFDataExtractor _str_offset_data, const DWARFDataExtractor _str_data, const bool offset_is_64_bit,

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

labath added a comment. I have a high-level question/comment. Are you planning to implement debug_macro reading in llvm-dwarfdump? Even if you aren't, I am expecting that you will be asked to do that as a part of testing for your debug_macro generation patch... And in that case, it would be

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX updated this revision to Diff 237909. SouraVX added a comment. Thank you everyone, for taking out time and reviewing this. Addressed @clayborg review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72597/new/ https://reviews.llvm.org/D72597 Files:

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

aprantl added inline comments. Comment at: lldb/test/Shell/Commands/dwarf5-macro.test:1 +# REQUIRES: x86 +# This test checks lldb macro expansion when macro section shafik wrote: > Is there a reason why we would only want to test this feature on x86? Presumably

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

shafik added a reviewer: shafik. shafik added inline comments. Comment at: lldb/test/Shell/Commands/dwarf5-macro.test:1 +# REQUIRES: x86 +# This test checks lldb macro expansion when macro section Is there a reason why we would only want to test this feature on

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp:62 +const DWARFDataExtractor _str_offset_data, const DWARFDataExtractor _str_data, const bool offset_is_64_bit, lldb::offset_t *offset, SymbolFileDWARF

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61782 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX marked an inline comment as done. SouraVX added inline comments. Comment at: lldb/test/Shell/Commands/Inputs/dwarf5-macro.s:1 + .text + .file "test.c" This file is generated via clang/llvm with macro section support. -- will upstream that

[Lldb-commits] [PATCH] D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro.

SouraVX created this revision. SouraVX added reviewers: JDevlieghere, clayborg, labath. SouraVX added a project: LLDB. Herald added subscribers: lldb-commits, aprantl. Herald added a reviewer: jdoerfert. This patch adds support for DWARFv5 new forms: DW_MACRO_define_strx, DW_MACRO_undef_strx.