[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-16 Thread Derek Schuff via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9b3254dbf9f6: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging (authored by paolosev, committed by dschuff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-16 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72650/new/ https://reviews.llvm.org/D72650 ___

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-15 Thread Paolo Severini via Phabricator via lldb-commits
paolosev updated this revision to Diff 238342. paolosev added a comment. Modified test to have two "inlined" yaml files and use "yaml2obj --docnum". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72650/new/ https://reviews.llvm.org/D72650 Files:

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-15 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D72650#1820897 , @paolosev wrote: > In D72650#1819403 , @labath wrote: > > > The patch looks pretty good. A reasonable way to test this would be again > > via `lldb-test object-file` . Th

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-14 Thread Paolo Severini via Phabricator via lldb-commits
paolosev updated this revision to Diff 238177. paolosev added a comment. Rebasing from D71575 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72650/new/ https://reviews.llvm.org/D72650 Files: lldb/source/API/Syst

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-14 Thread Paolo Severini via Phabricator via lldb-commits
paolosev added a comment. In D72650#1819403 , @labath wrote: > The patch looks pretty good. A reasonable way to test this would be again via > `lldb-test object-file` . The command dumps the "unified section list" of the > module, so if the debug info se

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-14 Thread Paolo Severini via Phabricator via lldb-commits
paolosev updated this revision to Diff 238128. paolosev added a comment. Added "lldb-test object-file" test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72650/new/ https://reviews.llvm.org/D72650 Files: lldb/source/API/SystemInitializerFull.cp

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-14 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. The patch looks pretty good. A reasonable way to test this would be again via `lldb-test object-file` . The command dumps the "unified section list" of the module, so if the debug info sections show up there, you know the symbol vendor has done it's job. You can look at

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-13 Thread Paolo Severini via Phabricator via lldb-commits
paolosev created this revision. paolosev added reviewers: clayborg, labath, aprantl, sbc100, teemperor. paolosev added a project: LLDB. Herald added subscribers: lldb-commits, sunfish, aheejin, jgravelle-google, mgorny. Add plugin class SymbolVendorWasm, with the logic to manage debug symbols for