This revision was automatically updated to reflect the committed changes.
Closed by commit rGb53d44b17a16: dotest.py: Add option to pass extra lldb
settings to dotest (authored by aprantl).
Changed prior to commit:
https://reviews.llvm.org/D72662?vs=237803=238072#toc
Repository:
rG LLVM
aprantl marked an inline comment as done.
aprantl added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:52
+# Any overridden settings.
+settings = []
+
labath wrote:
> JDevlieghere wrote:
> > To initialize settings to a empty
labath added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:787
+def disabledynamics():
+setSetting('target.prefer-dynamic-value', 'no-dynamic-values')
jingham wrote:
> labath wrote:
> > Maybe you could even put this as the
jingham added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:787
+def disabledynamics():
+setSetting('target.prefer-dynamic-value', 'no-dynamic-values')
labath wrote:
> Maybe you could even put this as the default value for the
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Seems reasonable.
Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:52
+# Any overridden settings.
+settings = []
+
JDevlieghere wrote:
> To
JDevlieghere added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:52
+# Any overridden settings.
+settings = []
+
To initialize settings to a empty dictionary this should be `{}` or `dict()`.
CHANGES SINCE LAST ACTION
aprantl created this revision.
aprantl added reviewers: JDevlieghere, labath.
aprantl added a project: LLDB.
The primary motivation for this is to add another dimension to the Swift LLDB
test matrix, but this seems generally useful.
https://reviews.llvm.org/D72662
Files:
