[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG67420f1b0e9c: [lldb/Util] Add a utility to run transparently capture and replay tests. (authored by JDevlieghere). Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/utils/lldb-repro/lldb-repro.py:24 +def help(): +print("usage: {}: /path/to/lldb capture|replay [args]".fmt(sys.argv[0])) + labath wrote: > I guess you don't ne

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

labath accepted this revision. labath added inline comments. Comment at: lldb/tools/lldb-repro/lldb-repro.h.cmake:12 + +#cmakedefine LLDB_TEST_EXECUTABLE "${LLDB_TEST_EXECUTABLE}" + JDevlieghere wrote: > labath wrote: > > JDevlieghere wrote: > > > labath wrote: >

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/tools/lldb-repro/lldb-repro.h.cmake:12 + +#cmakedefine LLDB_TEST_EXECUTABLE "${LLDB_TEST_EXECUTABLE}" + labath wrote: > JDevlieghere wrote: > > labath wrote: > > >

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere updated this revision to Diff 238837. JDevlieghere marked 11 inline comments as done. JDevlieghere added a comment. - Remove environment variables CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72823/new/ https://reviews.llvm.org/D72823 Files: lldb/test/Shell/Reproducer/l

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

labath added inline comments. Comment at: lldb/test/Shell/helper/toolchain.py:13 + +def _lldb_init(config): +return os.path.join(config.test_exec_root, 'Shell', 'lit-lldb-init') Maybe `_get_lldb_init_path`? This way it looks like this function is doing some

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/utils/lldb-repro/lldb-repro.py:49 +# run again but this time every invocation of lldb replays the previously +# recorded session. +if __name__ == '__main__': apran

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere updated this revision to Diff 238626. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72823/new/ https://reviews.llvm.org/D72823 Files: lldb/CMakeLists.txt lldb/test/Shell/Reproducer/lit.local.cfg lldb/test/Shell/helper/toolchain.py lldb/test/Shell/lit.cfg.py lldb/ut

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

aprantl added inline comments. Comment at: lldb/utils/lldb-repro/lldb-repro.py:49 +# run again but this time every invocation of lldb replays the previously +# recorded session. +if __name__ == '__main__': Thanks! Sorry for being such a nuisance, but I think this

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere updated this revision to Diff 238597. JDevlieghere added a comment. Add a comment explaining the purpose of the utility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72823/new/ https://reviews.llvm.org/D72823 Files: lldb/CMakeLists.txt lldb/test/Shell/Reproducer/lit.l

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

aprantl added inline comments. Comment at: lldb/utils/lldb-repro/lldb-repro.py:1 +#!/usr/bin/env python + Could we add a top-level comment (and/or a Usage: message) that explains what this tool is used for? That's not really obvious for someone who hasn't read

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere updated this revision to Diff 238554. JDevlieghere added a comment. - Convert to Python - Integrate with lit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72823/new/ https://reviews.llvm.org/D72823 Files: lldb/CMakeLists.txt lldb/test/Shell/Reproducer/lit.local.cfg l

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

aprantl added inline comments. Comment at: lldb/tools/lldb-repro/lldb-repro.h.cmake:5 +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// aprantl wrote: > Out of curiosity, is the `Copyrigh

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

aprantl added inline comments. Comment at: lldb/test/Shell/lit.cfg.py:42-46 if 'LLDB_CAPTURE_REPRODUCER' in os.environ: config.environment['LLDB_CAPTURE_REPRODUCER'] = os.environ[ 'LLDB_CAPTURE_REPRODUCER'] +if 'LLDB_REPRO_CAPTURE' in os.environ: + config.environment[

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. In D72823#1824152 , @labath wrote: > Considered making this a python script? I think that makes sense Comment at: lldb/test/Shell/lit.cfg.py:42-46 if 'LLDB_

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

labath added a comment. Considered making this a python script? Comment at: lldb/tools/lldb-repro/lldb-repro.h.cmake:12 + +#cmakedefine LLDB_TEST_EXECUTABLE "${LLDB_TEST_EXECUTABLE}" + labath wrote: > Are you sure this will work fine with multi-config generator

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

labath added a comment. This seems like it could be useful. Some random questions inline.. Comment at: lldb/test/Shell/lit.cfg.py:42-46 if 'LLDB_CAPTURE_REPRODUCER' in os.environ: config.environment['LLDB_CAPTURE_REPRODUCER'] = os.environ[ 'LLDB_CAPTURE_REPRODUCER']

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere created this revision. JDevlieghere added reviewers: labath, friss. Herald added a subscriber: mgorny. Herald added a project: LLDB. This patch introduces a small new tool `(lldb-repro`) to transparently capture and replay debugger sessions from the driver. The goal is to run the she