[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread pre-merge checks [bot] via Phabricator via lldb-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61936 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread Cyndy Ishida via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG24fca5cd7128: [lldb] add to gdb to lldb doc (authored by cishida). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72898/new/ https://reviews.llvm.org/D72898

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread Cyndy Ishida via Phabricator via lldb-commits
cishida updated this revision to Diff 238688. cishida added a comment. Updating to fix copy/paste error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72898/new/ https://reviews.llvm.org/D72898 Files: lldb/docs/use/map.rst Index:

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with Jim's comment addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72898/new/ https://reviews.llvm.org/D72898

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. There's a copy paste error in the first header. Other than that, this is fine, thanks for adding the entries! Comment at: lldb/docs/use/map.rst:613 + + Enable a breakpoint. + Shouldn't that be

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread pre-merge checks [bot] via Phabricator via lldb-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61936 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread Cyndy Ishida via Phabricator via lldb-commits
cishida created this revision. cishida added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, ributzka, dexonsmith. Herald added a project: LLDB. - enabling and disabling a breakpoint were missing. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72898 Files: