mib added a comment.
The test seems to fail on certain linux distros (fedora and archlinux) ...
Since it's not a breaking change, I sent a patch to skip it on linux, until I
can reproduce it on those platform and fix the issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jankratochvil added a comment.
Even with the latest variant (commit
`7ebe9cc4fc2d97ec0ed2a6038be25b2a7ed1aac2`) I am getting on Fedora 30 x86_64:
/home/jkratoch/redhat/llvm-monorepo/lldb/test/Shell/Recognizer/assert.test:5:10:
error: CHECK: expected string not found in input
# CHECK:
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7ebe9cc4fc2d: [lldb/Target] Add Assert StackFrame Recognizer
(authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73303/new/
mib updated this revision to Diff 242926.
mib added a comment.
This revision is now accepted and ready to land.
Fixing the memory management bug should hopefully solve the Linux and Windows
Issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
mib reopened this revision.
mib added a comment.
This revision is now accepted and ready to land.
There are still some bugs on Windows and Linux that need to investigated ...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73303/new/
friss added inline comments.
Comment at: lldb/source/API/SBThread.cpp:328-329
if (stop_info_sp) {
-const char *stop_desc = stop_info_sp->GetDescription();
+const char *stop_desc =
+exe_ctx.GetThreadPtr()->GetStopDescription().data();
labath added a comment.
It looks like there is still some memory corruption going on:
lldb) target create --core
"../llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump/fizzbuzz_no_heap.dmp"
(lldb) bt
* thread #1, stop reason = Exception 0xc005
max-kudr added a comment.
This broke LLDB tests on Windows Build Bot
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13415
Can you please fix it or revert it? Thank you!
Failing Tests (4):
lldb-api ::
commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py
mib added inline comments.
Comment at: lldb/source/Target/StackFrameRecognizer.cpp:95
const SymbolContext =
-frame->GetSymbolContext(eSymbolContextModule | eSymbolContextFunction);
+frame->GetSymbolContext(eSymbolContextEverything);
ConstString
mib updated this revision to Diff 242634.
mib marked 5 inline comments as done.
mib added a comment.
Fixed the corrupted stop reason description.
Fixed linux support for public symbols.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73303/new/
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2b7f32892b76: [lldb/Target] Add Assert StackFrame Recognizer
(authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73303/new/
labath added a comment.
Since the failure reason was not very obvious from the bot message, I took a
quick look, and to save you the trouble of reproducing this, here's what I
found:
The reason the new test failed was because the symbols you are searching for
(`__GI_raise`,
friss added a comment.
This generally looks good. I'm still not fond of registering this in the Target
itself. But I don't have a immediately better idea as we don't have a C
language runtime.
A couple more comments/questions that can be addressed as followups:
Comment at:
This revision was automatically updated to reflect the committed changes.
Closed by commit rG03a6b858fde5: [lldb/Target] Add Assert StackFrame Recognizer
(authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73303/new/
mib updated this revision to Diff 240899.
mib added a comment.
Added early return in `AssertFrameRecognizer::RecognizeFrame`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73303/new/
https://reviews.llvm.org/D73303
Files:
mib marked an inline comment as done.
mib added inline comments.
Comment at: lldb/source/Target/AssertFrameRecognizer.cpp:155
+
+ most_relevant_frame_sp = thread_sp->GetStackFrameAtIndex(
+ std::min(frame_index + 1, last_frame_index));
JDevlieghere
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM with one inline comment, but let's give the other reviewers a chance to
take another look before landing this.
Comment at:
mib updated this revision to Diff 240744.
mib marked 2 inline comments as done.
mib retitled this revision from "[lldb/Target] Add Abort StackFrame Recognizer"
to "[lldb/Target] Add Assert StackFrame Recognizer".
mib edited the summary of this revision.
mib added a comment.
Renamed
18 matches
Mail list logo
