[Lldb-commits] [PATCH] D73345: [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source

2020-01-29 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGab8b22d1c2d9: [lldb] Don't create duplicate declarations when completing a forward… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73

[Lldb-commits] [PATCH] D73345: [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source

2020-01-27 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73345/new/ https://reviews.llvm.org/D73345 ___ lldb-commits

[Lldb-commits] [PATCH] D73345: [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source

2020-01-24 Thread Pavel Labath via Phabricator via lldb-commits
labath resigned from this revision. labath added a comment. The description makes sense to me but I don't know much about this stuff. I'll leave it to @shafik to ack this... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73345/new/ https://reviews.llvm.org/D733

[Lldb-commits] [PATCH] D73345: [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source

2020-01-24 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added reviewers: shafik, labath. Herald added subscribers: lldb-commits, JDevlieghere, abidh, aprantl. Herald added a project: LLDB. I noticed this strange line in `ASTImporterDelegate::ImportDefinitionTo` which doesn't make a lot of sense: to_tag->se