[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

diazhector98 updated this revision to Diff 240715. diazhector98 edited the summary of this revision. diazhector98 added a comment. int32 to int Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files: lldb

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

diazhector98 updated this revision to Diff 240717. diazhector98 marked an inline comment as done. diazhector98 added a comment. changed int to size_t to avoid warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

labath added a comment. Thanks for the patch. I don't know much about the LSP protocol, but I see opportunities for simplifying the string chopping code. See the inline comment for what /I think/ should be the equivalent code. It has also occurred to me that this may break for expressions cont

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

teemperor added a comment. I don't really know the vscode plugin code but I pointed out when this was implemented that the whole token replacement mechanism that LLDB's completion API uses is really hard to get right. If you're at it, you might al

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

diazhector98 updated this revision to Diff 240908. diazhector98 added a comment. Simplifying code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vsc

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

diazhector98 updated this revision to Diff 240916. diazhector98 marked an inline comment as done. diazhector98 added a comment. Added tests for spaces between member operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG45e3f6660cf4: Auto-completion bug fix for dot operator (authored by Hector Diaz , committed by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE L