[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 246162. kwk added a comment. - Clear formatting - Make list private again - Remove open from CommandObjectBreakpoint.cpp - Remove change in unrelated file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ ht

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 246160. kwk added a comment. Updated tests and code to remove the --search-source-files flag and make it the default behavior to also search source files. TODO: rename class SearchFilterByModuleListAndCU to something more meaningful when an agreement on the beh

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

jingham added a comment. In D74136#1871751 , @labath wrote: > In D74136#1870029 , @jingham wrote: > > > In D74136#1869622 , @kwk wrote: > > > > > @labath @jingham to summariz

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

jingham added a comment. This way the only bit of the matrix of "restricting function name breakpoints by containing source file" that we don't support is "set a breakpoint on this function, but ONLY when it is inlined into another CU, NOT when it is in its defining CU." That seems the least u

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

labath added a comment. In D74136#1870029 , @jingham wrote: > In D74136#1869622 , @kwk wrote: > > > @labath @jingham to summarize from what I read here and what I chatted > > about with @labath , the following is

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

jingham added a comment. In D74136#1869622 , @kwk wrote: > @labath @jingham to summarize from what I read here and what I chatted about > with @labath , the following is a possible way to go for now, right? > > 1. We're not going to introduce my flag. >

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk added a comment. @labath @jingham to summarize from what I read here and what I chatted about with @labath , the following is a possible way to go for now, right? 1. We're not going to introduce my flag. 2. You're both not perfectly happy with the way things are documented at the moment an

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

jingham added a comment. In D74136#1862246 , @labath wrote: > In D74136#1862200 , @jingham wrote: > > > Is there ever a reason other than performance why you would want NOT to > > consult both the Compile Unit name

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

labath added a comment. In D74136#1862200 , @jingham wrote: > Is there ever a reason other than performance why you would want NOT to > consult both the Compile Unit name and also look for DW_AT_decl_file? That > doesn't seem clear to me. > > If the onl

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

jingham added a comment. Is there ever a reason other than performance why you would want NOT to consult both the Compile Unit name and also look for DW_AT_decl_file is performance? That doesn't seem clear to me. If the only worry is performance, and except for that you would really always wa

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

labath added a comment. I think that having this behavior key off of a flag is really confusing. I think the most sensible behavior here would be to introduce a new option like `--compile-unit` and have that behave like the current --file+--function mode. This would free up the --file argument

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk created this revision. Herald added subscribers: lldb-commits, dexonsmith, aprantl, mehdi_amini, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. kwk planned changes to this revision. kwk added a comment. I plan to refactor some of this patch. To set a breakpoint on

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk planned changes to this revision. kwk added a comment. I plan to refactor some of this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 ___ lldb-commi