JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h:66
/// Non-null value means we haven't built the index yet.
+ SymbolFileDWARF *m_dwarf;
labath wrote:
> JDevlieghere wrote:
> > This seems inverted?
> A
labath added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h:66
/// Non-null value means we haven't built the index yet.
+ SymbolFileDWARF *m_dwarf;
JDevlieghere wrote:
> This seems inverted?
Actually, it is correct, al
This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rG0f7cfb25432e: [lldb/DWARF] Don't index dwp file
multiple times (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D74964?vs=245850&id=246147
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Seems straightforward.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h:66
/// Non-null value means we haven't built the index yet.
+ Sym
labath created this revision.
labath added reviewers: clayborg, JDevlieghere, aprantl.
Herald added a subscriber: arphaman.
Herald added a project: LLDB.
When we added support for type units in dwo files, we changed the
"manual" dwarf index to index _all_ dwarf units in the dwo file instead
of jus
