[Lldb-commits] [PATCH] D75294: [lldb][NFC] Minor code cleanup in Editline.cpp

2020-03-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG467969161d94: [lldb/Core] Minor code cleanup in Editline.cpp (NFC) (authored by gedatsu217, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D75294?vs=247953&id=248628#toc

[Lldb-commits] [PATCH] D75294: [lldb][NFC] Minor code cleanup in Editline.cpp

2020-03-05 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Actually this LGTM (Jonas already caught the thing I wanted to complain about) but the commit message needs some improvements: - The title should contain "[NFC]" (which is short for "No functional change" and just means that you didn't change any functionality here. M