[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

2020-03-05 Thread Amara Emerson via Phabricator via lldb-commits
aemerson updated this revision to Diff 248567. aemerson added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. @omjavaid can you look over the lldb changes? I don't have the hardware to be able to actually run this test but I've tried to relax the checks. Reposi

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

2020-03-06 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. In D7#1908351 , @aemerson wrote: > @omjavaid can you look over the lldb changes? I don't have the hardware to be > able to actually run this test but I've tried to relax the checks. @aemerson I have moved these test to skip

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

2020-03-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Yep, that test really shouldn't be doing that. Historically, lldb has been avoiding architecture specific artifacts (like assembly) in its tests, but that didn't really work out here. That test has become a nightmare of architecture-specific assertions. If we're going t

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

2020-03-06 Thread Amara Emerson via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc1a97e992da6: Revert "Revert "[GlobalISel][Localizer] Enable intra-block localization of… (authored by aemerson). Changed prior to commit: https://reviews.llvm.org/D7?vs=248567&id=248898#toc Repos

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

2020-03-09 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. In D7#1909194 , @labath wrote: > Yep, that test really shouldn't be doing that. Historically, lldb has been > avoiding architecture specific artifacts (like assembly) in its tests, but > that didn't really work out here. Tha