[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

This revision was automatically updated to reflect the committed changes. Closed by commit rG8016d61e3cf4: [LLDB] CPlusPlusNameParser does not handles templated operator< properly (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

shafik updated this revision to Diff 253142. shafik marked 6 inline comments as done. shafik added a comment. Fixing up loose language in the comments and adding periods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76168/new/ https://reviews.llvm.org/D76168 Files: lldb/source/Plugi

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp:333 + + // When we generate debug info we add template parameters to names. + // Since we don't add a space between the name and the template parameter in

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

shafik updated this revision to Diff 252941. shafik marked 4 inline comments as done. shafik added a comment. Addressing comments: - Adding more detailed comments - Adding test for cases that currently fail b/c we don't enable C++20 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76168/ne

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp:333 + if (token.getKind() == tok::lessless) { +if (m_next_token_index + 1 < m_tokens.size()) { + clang::Token n_token = m_tokens[m_next_token_index + 1]; --

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

labath added a comment. In D76168#1929733 , @shafik wrote: > In D76168#1929211 , @labath wrote: > > > In D76168#1925176 , @shafik wrote: > > > > > Long-term I would like to m

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

shafik added a comment. In D76168#1929211 , @labath wrote: > In D76168#1925176 , @shafik wrote: > > > Long-term I would like to modify clang to stop doing that for LLDB, but > > LLDB will still have to support olde

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

labath added a comment. In D76168#1925176 , @shafik wrote: > Long-term I would like to modify clang to stop doing that for LLDB, but LLDB > will still have to support older compilers for a while. So I think this fix > is still needed. So is this some a

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

shafik added a comment. In D76168#1924539 , @hubert.reinterpretcast wrote: > I am not sure what the usage scenario is that this is meant to support. Is it > user input that tries to name a specialization of a template `operator<` > without separation to

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

hubert.reinterpretcast added a comment. I am not sure what the usage scenario is that this is meant to support. Is it user input that tries to name a specialization of a template `operator<` without separation to prevent tokenization as `operator<<`? I think that case should qualify as user err

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

labath added a comment. The approach seems reasonable to me. Comment at: lldb/unittests/Language/CPlusPlus/CPlusPlusLanguageTest.cpp:153-155 + // We expect these cases to fail until we turn on C++2a + // {"A::operator<=>", "A", "operator<=>"}, + // {"op

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

shafik created this revision. shafik added reviewers: aprantl, labath, jingham. shafik added a comment. My fix in `ConsumeOperator()` is not proper but if everyone feels this is correct approach I will create member functions to deal with this cleanly. Other approaches could be modifying `Extrac

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

shafik added a comment. My fix in `ConsumeOperator()` is not proper but if everyone feels this is correct approach I will create member functions to deal with this cleanly. Other approaches could be modifying `ExtractTokens()` to detect this case and generate two `tok::less`in place of `tok::le