[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda created this revision. jasonmolenda added reviewers: clayborg, JDevlieghere, aprantl. jasonmolenda added a project: LLDB. Herald added a subscriber: mgrang. In addition to the traditional nlist records in Mach-O binaries, the dynamic linker dyld has a trie structure that it uses to r

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

aprantl added a comment. I only have a bunch of superficial comments but this seems reasonable as far as I can tell. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1988 +bool add_this_entry = false; if (EXPORT_SYMBOL_FLAGS_REEXPORT & e.entry.fla

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda updated this revision to Diff 252756. jasonmolenda added a comment. Update patch with Adrian's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76758/new/ https://reviews.llvm.org/D76758 Files: lldb/source/Plugins/ObjectFi

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda marked 11 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:4499 +std::sort(external_sym_trie_entries.begin(), + external_sym_trie_entries.end(), sort_by_address); +

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda marked 2 inline comments as done. jasonmolenda added a comment. Thanks Adrian, great comments, incorporated most of them. The use of the block to search the trie entries when eliminating duplication between nlist/tries was a good idea, much cleaner now. Comment

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1990 import_name[0]) { + // add symbols that are reexport symbols with a valid import name + add_this_entry = true; aprantl wrote: > Super

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jingham added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1926 + bool IsSymbolAlreadyPresent() { +if (flags == LLDB_INVALID_ADDRESS) + return true; JDevlieghere wrote: > `return flags == LLDB_INVALID_ADDRESS` T

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

clayborg added a comment. So I know the mach-o symbol table parsing code is a mess already, but it seems like this patch can be simpler if we make a std::set at the top of ObjectFileMachO::ParseSymtab() and every time we add a symbol that has a valid address value, add the file addr to this set

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda added a comment. In D76758#1944612 , @clayborg wrote: > So I know the mach-o symbol table parsing code is a mess already, but it > seems like this patch can be simpler if we make a std::set at > the top of ObjectFileMachO::ParseSymtab() and

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0a5af906b41: Merge in symbols from Mach-O dyld trie to the symbol table (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76758/new/

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda updated this revision to Diff 253293. jasonmolenda added a comment. Updated the patch to incorporate Jonas and Greg's suggestions. Most importantly, Greg's suggestion to have a set of addresses added to the symbol table; now that we've added a third symbol source, this was a much c

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

clayborg added a comment. Much cleaner! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76758/new/ https://reviews.llvm.org/D76758 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.