This revision was automatically updated to reflect the committed changes.
Closed by commit rGa3237f861cc2: [lldb/Reproducers] Simplify LLDB_RECORD macros
(authored by JDevlieghere).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78141/new/
https://re
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Very nice.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78141/new/
https://reviews.llvm.org/D78141
___
lldb-commits mailing list
lldb-c
JDevlieghere updated this revision to Diff 257738.
JDevlieghere marked 3 inline comments as done.
JDevlieghere added a comment.
Address Pavel's code review feedback
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78141/new/
https://reviews.llvm.org/D78141
Files:
lldb/include/lldb/Utili
labath added a comment.
This looks even better than I hoped. I think this is a worthwhile
simplification even without the followup patches. Just a couple of questions
inline...
Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:117-135
#define LLDB_RECORD_CONS
JDevlieghere updated this revision to Diff 257460.
JDevlieghere added a comment.
Add a comment
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78141/new/
https://reviews.llvm.org/D78141
Files:
lldb/include/lldb/Utility/ReproducerInstrumentation.h
Index: lldb/include/lldb/Utility/Repro
JDevlieghere created this revision.
JDevlieghere added a reviewer: labath.
JDevlieghere added a project: LLDB.
Redefine the LLDB_RECORD macros in terms of a common uber-macro to reduce code
duplication across them.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D78141
Files:
lldb/include
