This revision was automatically updated to reflect the committed changes.
Closed by commit rG52712d3ff7a2: Re-land get rid of
PythonInteger::GetInteger() (authored by lawrence_danna).
Changed prior to commit:
https://reviews.llvm.org/D78462?vs=259916=262908#toc
Repository:
rG LLVM Github
omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
Thanks for getting this fixed. Looks good now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78462/new/
https://reviews.llvm.org/D78462
lawrence_danna added a comment.
@omjavaid ok to re-land?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78462/new/
https://reviews.llvm.org/D78462
___
lldb-commits mailing list
lawrence_danna updated this revision to Diff 259916.
lawrence_danna added a comment.
rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78462/new/
https://reviews.llvm.org/D78462
Files:
lldb/bindings/python/python-typemaps.swig
labath accepted this revision.
labath added a comment.
Still looks good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78462/new/
https://reviews.llvm.org/D78462
___
lldb-commits mailing list
lawrence_danna updated this revision to Diff 259700.
lawrence_danna added a comment.
rebased
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78462/new/
https://reviews.llvm.org/D78462
Files:
lldb/bindings/python/python-typemaps.swig
lawrence_danna added a comment.
@omjavaid sorry I didn't catch that on pre-submit testing.
`PyLong_AsLongLong` and friends do not automatically convert on python2 like
they do on python3. It's fixed now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
lawrence_danna updated this revision to Diff 259659.
lawrence_danna added a comment.
fix python2 projblems
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78462/new/
https://reviews.llvm.org/D78462
Files:
lldb/bindings/python/python-typemaps.swig
This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG478619cf9a24: Revert get rid of
PythonInteger::GetInteger() (authored by omjavaid).
Changed prior to commit:
omjavaid requested changes to this revision.
omjavaid added a comment.
This revision now requires changes to proceed.
I have temporarily reverted this change to turn buildbot green.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78462/new/
omjavaid reopened this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
This causes multiple test failures on LLDB AArch64 Linux buildbot.
http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/3695
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
This revision was automatically updated to reflect the committed changes.
Closed by commit rG737521217295: get rid of PythonInteger::GetInteger()
(authored by lawrence_danna).
Changed prior to commit:
https://reviews.llvm.org/D78462?vs=259131=259134#toc
Repository:
rG LLVM Github Monorepo
lawrence_danna updated this revision to Diff 259131.
lawrence_danna marked 4 inline comments as done.
lawrence_danna added a comment.
wrap long line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78462/new/
https://reviews.llvm.org/D78462
Files:
lawrence_danna added inline comments.
Comment at: lldb/bindings/python/python-wrapper.swig:585-597
+llvm::Expected result = pfunc.Call(PythonString(child_name));
-if (!result.IsAllocated())
-return UINT32_MAX;
+long long retval =
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good. I'll leave it up to you to consider whether the `PySys_WriteStderr`
thingy is a good idea.
Comment at: lldb/bindings/python/python-typemaps.swig:72
+
lawrence_danna updated this revision to Diff 258831.
lawrence_danna added a comment.
fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78462/new/
https://reviews.llvm.org/D78462
Files:
lldb/bindings/python/python-typemaps.swig
lawrence_danna added inline comments.
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:3153-3159
+ long long py_return = unwrapOrSetPythonException(
+ As(implementor.CallMethod(callee_name)));
// if it fails, print the error but
lawrence_danna updated this revision to Diff 258810.
lawrence_danna marked 4 inline comments as done.
lawrence_danna added a comment.
review fixes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78462/new/
https://reviews.llvm.org/D78462
Files:
labath added inline comments.
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:55
+return obj.takeError();
+ return obj.get().AsUnsignedLongLong();
+}
`obj->AsUnsignedLongLong()` ?
Comment at:
lawrence_danna created this revision.
lawrence_danna added reviewers: labath, jasonmolenda, JDevlieghere, vadimcn.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
One small step in my long running quest to improve python exception handling in
LLDB. Replace GetInteger()
20 matches
Mail list logo
