[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

rnk added a comment. I will take a look and try to reland this, since I requested the assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79447/new/ https://reviews.llvm.org/D79447 ___ lldb-commits m

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

hans added a comment. In D79447#2041250 , @hans wrote: > > - Added assert in `emitDebugInfoForUDTs` to ensure no lowering can occur > > during UDT emission, as suggested by @rnk > > It seems we hit the assert in Chromium. Here's a reproducer: > https://b

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

hans added a comment. > - Added assert in `emitDebugInfoForUDTs` to ensure no lowering can occur > during UDT emission, as suggested by @rnk It seems we hit the assert in Chromium. Here's a reproducer: https://bugs.chromium.org/p/chromium/issues/detail?id=1083877#c3 (I'll try to create a short

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

This revision was automatically updated to reflect the committed changes. aganea marked 4 inline comments as done. Closed by commit rG76c5f277f25e: Re-land [Debug][CodeView] Emit fully qualified names for globals (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D79447?vs=

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, modulo ifdef adjustment Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3125-3126 } else { // FIXME: Currently this only emits the global variables in the I

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

aganea reopened this revision. aganea added a comment. This revision is now accepted and ready to land. Could you please take another look? Thank you in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79447/new/ https://reviews.llvm.org/D794

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

aganea updated this revision to Diff 263450. aganea added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reopening because I had to revert. - Fix lldb's variables.test - Fix type lowering, as described here: D79512 - Added asser