[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

labath added a comment. In D79563#2024854 , @teemperor wrote: > Changing might actually be a better idea as this way we at least know this > isn't crashing. Ok, I'll change the expectation then. Comment at: lldb/packages/Python/lldbs

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rGba898282bc20: [lldb/test] Make "inline" tests handle multiple statements at the same location (authored by labath). Changed prior to commit: https://reviews.llvm

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

JDevlieghere accepted this revision. JDevlieghere added a comment. Nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79563/new/ https://reviews.llvm.org/D79563 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

vsk added a comment. Thanks! LGTM, modulo any comments Raphael may have about the test change. Comment at: lldb/packages/Python/lldbsuite/test/lldbinline.py:155 process, lldb.eStopReasonBreakpoint) -breakpoint_id = thread.GetStopReasonDataAtIndex(0)

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

shafik added a comment. Thank you! I am pleasantly surprised there was only one hidden broken test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79563/new/ https://reviews.llvm.org/D79563 ___ lldb-com

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Will this also fix these problems? int i = 0; //% code_that_is_executed //% that that isn't executed as it's behind an empty line :( I think disabling the check is fine. You can

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

teemperor added a comment. Changing might actually be a better idea as this way we at least know this isn't crashing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79563/new/ https://reviews.llvm.org/D79563 _

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

labath added a reviewer: teemperor. labath marked an inline comment as done. labath added inline comments. Comment at: lldb/test/API/commands/expression/dollar-in-variable/main.c:20 //%self.expect("expr int $foo = 123", error=True, substrs=["declaration conflicts"]) - return

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

labath updated this revision to Diff 262614. labath added a comment. - disable a check that fails now. AFAICT, this never worked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79563/new/ https://reviews.llvm.org/D79563 Files: lldb/packages/Pytho

[Lldb-commits] [PATCH] D79563: [lldb/test] Make "inline" tests handle multiple statements at the same location

labath created this revision. labath added reviewers: vsk, JDevlieghere. Herald added a project: LLDB. The test machinery translates each continuous block of "//%" comments into a single breakpoint. If there's no code between the blocks the breakpoints will end up at the same location in the progr