vsk created this revision.
vsk added reviewers: JDevlieghere, jingham, shafik.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
TestNSDictionarySynthetic sets up an NSURL which does not initialize its
_baseURL member. When the test runs and we print out the NSURL, we print
ou
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM. We discussed adding this during the original review, but I left it out
because we could always add it if we needed it. Turns out we do!
Repository:
rG LLVM Github Monorepo
shafik added inline comments.
Comment at: lldb/test/API/lldbtest.py:123
# In Python 2, string objects can contain Unicode characters.
-out = out.decode('utf-8')
-err = err.decode('utf-8')
+out = out.decode('utf-8', 'replace')
+
vsk marked 2 inline comments as done.
vsk added inline comments.
Comment at: lldb/test/API/lldbtest.py:123
# In Python 2, string objects can contain Unicode characters.
-out = out.decode('utf-8')
-err = err.decode('utf-8')
+out = o
This revision was automatically updated to reflect the committed changes.
vsk marked an inline comment as done.
Closed by commit rGf807d0b4acdb: [lldb/test] Fix for flakiness in
TestNSDictionarySynthetic (authored by vsk).
Changed prior to commit:
https://reviews.llvm.org/D79645?vs=262927&id=26
