[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9d7b458c094: Use IPv4 for Android connections (authored by emrekultursay, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ ht

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

emrekultursay added a comment. I admit I don't fully understand the details of that CL and how it may interact with this one. However, I can say that I verified this CL with an Android device connected over IPv6. So, I think this CL is ready to be submitted. (I don't have commit access). Repo

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

clayborg added a comment. In D79757#2036618 , @aadsm wrote: > @clayborg the support we added was for the lldb-server. ok, phew! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llv

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

aadsm added a comment. @clayborg the support we added was for the lldb-server. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llvm.org/D79757 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

clayborg added a comment. There was a patch previous to this that enabled IPv6. We need IPv6 on some computers here at Facebook. Can you check this file's log and look at the IPv6 patch and make sure this doesn't just undo that patch prior to committing this? If it does undo that patch, maybe w

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

clayborg added a comment. nice catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79757/new/ https://reviews.llvm.org/D79757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D79757: Use IPv4 for Android connections

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. This looks good now. As an aside, it would be nice if adb actually started supporting ipv6 -- it's over 20 years old now... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC