[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

This revision was automatically updated to reflect the committed changes. Closed by commit rGa03dc8c9fa8e: [lldb] Add basic -flimit-debug-info support to expression evaluator (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath updated this revision to Diff 274768. labath added a comment. - redo the sanity check in the test (get_field_array does not include inherited types) - skip gmodules test flavours due to pr46284 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM beside the `_check_type` check always passing as discussed on IRC. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81561/new/

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath marked an inline comment as done. labath added a comment. So, what do you make of this patch now, Raphael? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81561/new/ https://reviews.llvm.org/D81561

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath updated this revision to Diff 272650. labath marked 4 inline comments as done. labath added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81561/new/ https://reviews.llvm.org/D81561 Files:

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath marked 4 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp:891 + +if (auto *proxy = llvm::dyn_cast( +getToContext().getExternalSource())) { teemperor wrote: >

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think the approach here makes sense. The only issue I see is how we get the complete replacement type (see the inline comment). There is the issue if having an artificial

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath added a comment. In D81561#2086435 , @clayborg wrote: > If we run into a class in the AST importer that was forcefully completed and > we can't find a better definition, what do we do? Error out? Do what we did. > I would like there to be a nice

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath updated this revision to Diff 270097. labath added a comment. add more comments and logging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81561/new/ https://reviews.llvm.org/D81561 Files:

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

aprantl added a comment. It's great to see this being addressed! I have a high-level question: When completing types across lldb::Modules — in which ASTContext is the complete type created? Since a per-module TypeSystem can be shared by many debuggers, I want to make sure that types from

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

clayborg added a comment. If we run into a class in the AST importer that was forcefully completed and we can't find a better definition, what do we do? Error out? Do what we did. I would like there to be a nice log line in the "log enable lldb expr" to tell us when this happens so we can know

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

clayborg added a comment. The overall approach is what we had talked about previously and looks good as far as I can tell. I don't do enough expression parser work to give the accept on this, but I have no problems with what I see. If any expression parser experts are not on the reviewers,

[Lldb-commits] [PATCH] D81561: [lldb] Add basic -flimit-debug-info support to expression evaluator

labath created this revision. labath added reviewers: teemperor, clayborg, jingham. Herald added subscribers: aaron.ballman, aprantl. Herald added a reviewer: shafik. Herald added a reviewer: shafik. Herald added a project: LLDB. This patch adds support for evaluation of expressions referring to