[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Make lldb-vscode receive and process module events so that modules can be rendered in the IDE. Repository: rG LLVM Github Monorepo https://r

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So great first patch Yifan! A few things to fix up, see inlined comments. We need to add a test for lldb::SBTarget::eBroadcastBitSymbolsLoaded if possible. This can be done by st

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

labath added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:27-29 +self.assertTrue('a.out' in self.vscode.get_active_modules(), +'Module: a.out is loaded') +self.assertTrue('symbolFilePath' in sel

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 273378. aelitashen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Formatting the codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We need to add a test for the symbols added target notification. See my previous comment on stripping a.out to a.out.stripped and then using "a.out.stripped" as the main executab

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg added a comment. Here is a makefile that does stripping: llvm-project/lldb/test/API/lang/objc/objc-ivar-stripped/Makefile Then when creating the target, use a.out.stripped: exe = self.getBuildArtifact("a.out.stripped") symbols = exe = self.getBuildArtifact("a.out") target = self.

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen marked 3 inline comments as done. aelitashen added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:337-340 +std::string(module.GetFileSpec().GetFilename())); + std::string module_path = std::string(module.GetFileSpec().GetDirectory()) + +

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 274634. aelitashen added a comment. Make LLDB take care of the directory delimiter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files: clang/tools/clang-format/

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inline comments. Changes needed are: - test for eBroadcastBitSymbolsLoaded - add "version" to module info - test all data we expect in module info ('name', 'symbolFilePath', '

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276172. aelitashen added a comment. Add test for loading symbols, other module info and Add version to module info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Fi

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So looks like you didn't use "git commit --amend -a" again here. These changes are incremental changes on your patch which hasn't been submitted yet? Comment a

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276274. aelitashen added a comment. Fix messy diff stack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vsco

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just test for paths and this will be good to go! Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:35 +self.assertEqual(program_ba

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276294. aelitashen added a comment. Add Path Verification in Test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files: lldb/packages/Python/lldbsuite/test/tools/

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7f80159753b: [lldb-vscode] Add Support for Module Event (authored by aelitashen, committed by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg added a comment. In D82477#2145565 , @MaskRay wrote: > Hi, your git commit contains extra Phabricator tags. You can drop > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > commit with the following script: > > arcfilt

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

MaskRay added a subscriber: mehdi_amini. MaskRay added a comment. In D82477#2145967 , @clayborg wrote: > In D82477#2145565 , @MaskRay wrote: > > > Hi, your git commit contains extra Phabricator tags. You can drop >