[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

This revision was automatically updated to reflect the committed changes. Closed by commit rGb725142c8db8: [lldb] Fix type conversion in the Scalar getters (authored by labath). Changed prior to commit: https://reviews.llvm.org/D82772?vs=274127&id=275143#toc Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

labath marked 3 inline comments as done. labath added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:864 case e_uint512: -return static_cast( -llvm::APIntOps::RoundAPIntToDouble(m_integer)); teemperor wrote: > Seems unrelated to the pa

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with Raphael's and clang-format's comments addressed :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82772/new/ https://reviews.llvm.org/D82772 ___

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Beside some minor things this LGTM. Comment at: lldb/source/Utility/Scalar.cpp:864 case e_uint512: -return static_cast( -llvm::APIntOps::RoundAPIntToDoub

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

labath added a comment. Thanks for looking at this. Could you also tell me what you think of D82864 ? That's sort of a more safe/NFC-ish alternative to this patch, as it doesn't change behavior -- it just makes the current behavior more obvious. (It's technical

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

mib added a comment. Hey Pavel! Thanks for taking care of this. I started looking at it no long ago but I got sidetracked working on other stuff. I don't see anything wrong with the patch, looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

labath added a comment. Another possibility would be to rename `[US]LongLong` to something like `Get[SZ]ExtInteger` (similar to `APInt::get[SZ]ExtValue`) to make it clear what it does, and ditch the other getter functions. I've mean meaning to move this class away from using host types at some

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

JDevlieghere added a comment. + Ismail as he looked at this recently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82772/new/ https://reviews.llvm.org/D82772 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D82772: [lldb] Fix type conversion in the Scalar getters

labath created this revision. labath added reviewers: teemperor, JDevlieghere. Herald added a project: LLDB. The Scalar class claims to follow the C type conversion rules. This is true for the Promote function, but it is not true for the implicit conversions done in the getter methods. These func