[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fd77668b2cc: [LLDB] Add per-thread register infos shared pointer in gdb-remote (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 314325. omjavaid added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/source/Plugins/Process/Utility/DynamicRe

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid added a comment. @labath Is this ok for commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 309860. omjavaid added a comment. This update resolves review comments from @rovka and @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInf

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp:47-48 + // run-time update to register sizes and offsets.. + ProcessSP process_sp(GetProcess()); + if (process_sp) { +ProcessGDBRemote *gdb_process = Can't

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

rovka added a comment. Sorry, I had one more comment :) I think that should be all from my side. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:403 + m_register_info_sp = std::make_shared(); + m_register_info_sp->Clear(); Is it stil

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

labath added inline comments. Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.h:29 + DynamicRegisterInfo(DynamicRegisterInfo &) = default; void operator=(DynamicRegisterInfo &) = delete; rovka wrote: > I think operator= should be default

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

rovka added inline comments. Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.h:29 + DynamicRegisterInfo(DynamicRegisterInfo &) = default; void operator=(DynamicRegisterInfo &) = delete; I think operator= should be default too if the copy

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 308932. omjavaid added a comment. Added copy constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/source/Plugins/Process/U

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 308863. omjavaid added a comment. Updated after incorporating suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/s

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:34 ThreadGDBRemote &thread, uint32_t concrete_frame_idx, -GDBRemoteDynamicRegisterInfo ®_info, bool read_all_at_once, +GDBRemoteDynamicRegisterInfoSP reg_in

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 308340. omjavaid added a comment. Updated after re-base over D91241 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicReg

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 304728. omjavaid added a comment. Minor update after changes to D82863 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/Dynamic

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

labath added a comment. There are things I'd want to change here, but I think this is patch is fundamentally ok. Before going into that, I think we should first sort out the dependant patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid added a comment. @labath ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added a subscriber: kristof.beyls. Herald added a reviewer: rengolin. In gdb-remote process we have register infos defind GDBRemoteDynamicRegisterInfo reference. In past register infos have remained constant througout the