[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

labath added a comment. This seems fairly straight-forward to me, though I didn't dive into all the details. Given the amount of changed tests, it may be nice to separate the format change from the linking patch (so in the interim state, one could generate multiple abbrev tables, but there wou

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

jhenderson added inline comments. Comment at: llvm/include/llvm/ObjectYAML/DWARFEmitter.h:34 +private: + Data &DWARF; + std::map AbbrevID2Index; Would it make any sense to merge the `DWARFYAML::Data` class and `DWARFYAML::DWARFState` class at all? ==

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing marked an inline comment as done. Higuoxing added inline comments. Comment at: llvm/tools/obj2yaml/dwarf2yaml.cpp:19 #include +#include jhenderson wrote: > I'm slightly surprised you needed to add this. Did this not compile without > it? I guess i

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

jhenderson added a comment. In D83116#2130019 , @labath wrote: > What would you say if, instead of `AbbrevTableIndex`, we had a field like > `AbbrevTableID`. The main difference would be that this "ID" field can be > explicitly specified on the Abbrev ta

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing added a comment. In D83116#2130019 , @labath wrote: > What would you say if, instead of `AbbrevTableIndex`, we had a field like > `AbbrevTableID`. The main difference would be that this "ID" field can be > explicitly specified on the Abbrev tab

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

labath added a comment. What would you say if, instead of `AbbrevTableIndex`, we had a field like `AbbrevTableID`. The main difference would be that this "ID" field can be explicitly specified on the Abbrev table, and it does not have to be a sequentially increasing number (though it could of c

[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for emitting multiple abbrev tables.

Higuoxing marked 3 inline comments as done. Higuoxing added a comment. Newly added tests are marked by inline comments since too many tests are updated 😂. Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml:685 + +## c) Test that yaml2obj emits correct DWARF sections