vsk updated this revision to Diff 276280.
vsk added a comment.
Move locking up into lldb::Function, and leave a comment in SymbolFileDWARF
explaining why.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83359/new/
https://reviews.llvm.org/D83359
vsk planned changes to this revision.
vsk added a comment.
Hm, this doesn't totally fix the race. If the mutex is contested, the Function
instance may overwrite its m_call_edges vector.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83359/new/
vsk created this revision.
vsk added reviewers: jasonmolenda, friss, jingham.
Herald added a subscriber: aprantl.
Herald added a project: LLDB.
DWARF-parsing methods in SymbolFileDWARF which update module state
should take the module lock. Have ParseCallEdgesInFunction do this.
This could
