[Lldb-commits] [PATCH] D83957: [lldb/DWARF] Don't get confused by line sequences with tombstone values

This revision was automatically updated to reflect the committed changes. labath marked 3 inline comments as done. Closed by commit rGf3fab392f574: [lldb/DWARF] Dont get confused by line sequences with tombstone values (authored by labath). Changed prior to commit:

[Lldb-commits] [PATCH] D83957: [lldb/DWARF] Don't get confused by line sequences with tombstone values

MaskRay added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1040 std::unique_ptr sequence = LineTable::CreateLineSequenceContainer(); std::vector> sequences; While here, delete the initialization and move

[Lldb-commits] [PATCH] D83957: [lldb/DWARF] Don't get confused by line sequences with tombstone values

MaskRay added a comment. > Recently, lld has started debug info resolving relocations to > garbage-collected symbols as -1 Just mention D81784 :) > (instead of 0). This is not accurate. It resolves the relocation to `r_addend`. In many cases, r_addend is 0.

[Lldb-commits] [PATCH] D83957: [lldb/DWARF] Don't get confused by line sequences with tombstone values

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing that! Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1043 + for (const llvm::DWARFDebugLine::Sequence :

[Lldb-commits] [PATCH] D83957: [lldb/DWARF] Don't get confused by line sequences with tombstone values

labath created this revision. labath added reviewers: JDevlieghere, MaskRay. Herald added a subscriber: aprantl. Herald added a project: LLDB. Recently, lld has started debug info resolving relocations to garbage-collected symbols as -1 (instead of 0). For an unaware consumer this generated