[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

saugustine added a comment. This change has a subtle isse with wattr_get and friends: saved_opts isn't actually used, and the documentation for them says to always pass a nullptr. "The parameter opts is reserved for future use, applications must supply a null pointer." I fixed it in

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

mstorsjo added a comment. In D85145#2199045 , @teemperor wrote: > Same on Arch Linux. Should be fixed in > 45f9fc890705a8272e5253602f5506fdef4586e2 (I just removed the scope operator). Indeed it is, thanks! Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor added a comment. Same on Arch Linux. Should be fixed in 45f9fc890705a8272e5253602f5506fdef4586e2 (I just removed the scope operator). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85145/new/ https://reviews.llvm.org/D85145

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

mstorsjo added a comment. Herald added a subscriber: JDevlieghere. This broke compilation on Ubuntu 18.04: In file included from ../tools/lldb/source/Core/IOHandlerCursesGUI.cpp:17:0: ../tools/lldb/source/Core/IOHandlerCursesGUI.cpp: In member function ‘void

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG14406ca01fd3: [lldb][gui] use syntax highlighting also in gui mode (authored by llunak). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D85145?vs=282865=283498#toc

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Sorry was OOO. The source code is user input, so you can have anything in it. LLDB will happily read and return any file contents as long as it matches the source path. Like, create a

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

clayborg added a comment. LGTM. Raphael? You have any more comments? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85145/new/ https://reviews.llvm.org/D85145 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:486 + if (!string.consume_front("[")) { +llvm::errs() << "Missing '[' in color escape sequence.\n"; +continue; clayborg wrote: > So what will happen if we

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:486 + if (!string.consume_front("[")) { +llvm::errs() << "Missing '[' in color escape sequence.\n"; +continue; So what will happen if we actually get these

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak updated this revision to Diff 282865. llunak added a comment. Updated according to comments. I find some of the StringRef APIs flawed though: consume_front() returns true on success, but consumeInteger() returns false; consume_front() modifies the object, but drop_front() doesn't.

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak added a comment. In D85145#2192716 , @teemperor wrote: > I wonder if there is a reasonable way to test this. From what I understand > these attributes aren't in any output buffer that we could expect (e.g., with > a pexpect test). I'm not sure.

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. In D85145#2191658 , @llunak wrote: > In D85145#2191421 , @teemperor wrote: > >> Btw, the

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak added a comment. In D85145#2191421 , @teemperor wrote: > Btw, the highlighter supports any kind of delimiter string when > 'highlighting' source. So you could add a parameter for a custom highlighter > too and then pass a more convenient

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor added a reviewer: teemperor. teemperor added a comment. Btw, the highlighter supports any kind of delimiter string when 'highlighting' source. So you could add a parameter for a custom highlighter too and then pass a more convenient highlighter 'style' in to make the parsing simpler.

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. Use the same functionality as the non-gui mode, the colors just need translating to curses colors. Repository: rLLDB LLDB https://reviews.llvm.org/D85145 Files: