This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5d8eedee917d: Move Py_buffer_RAII to .h file so SWIG 2
doesnt have to parse it (authored by aadsm).
Repository:
rG LLVM Github Monorepo
CHANGES
aadsm updated this revision to Diff 287160.
aadsm added a comment.
After reading a bit more how clang-tidy works this isn't fixable because it
actually needs to compile it. I also didn't find a way to exclude a file from
it.
My plan is to just land this and then make a PR to add this file to
aadsm updated this revision to Diff 287149.
aadsm added a comment.
Moved the header file to be in Plugins/ScriptInterpreter/Python so clang-tidy
doesn't get confused solving include paths.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86381/new/
aadsm updated this revision to Diff 287144.
aadsm added a comment.
Added include guards, clang-format and python include
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86381/new/
https://reviews.llvm.org/D86381
Files:
lawrence_danna accepted this revision.
lawrence_danna added a comment.
This revision is now accepted and ready to land.
Looks fine to me, assuming that the tests pass.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86381/new/
aadsm created this revision.
aadsm added reviewers: clayborg, wallace, lawrence_danna.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
aadsm requested review of this revision.
Herald added a subscriber: JDevlieghere.
`struct Py_buffer_RAII` definition uses explicit deleted
