teemperor added a comment.
Seems like this were just some missing calls to initialize/terminate. I added
them in an ugly hotfix commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86389/new/
https://reviews.llvm.org/D86389
teemperor added a comment.
Pretty sure this broke some tests
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/23476/
Note: Google Test filter =
SymbolsTest.LocateExecutableSymbolFileForUnknownExecutableAndMissingSymbolFile
[==] Running 1 test from 1 test case.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa842950b62b6: [lldb] Add a SymbolFileProvider to record and
replay calls to dsymForUUID (authored by JDevlieghere).
Herald added a project: LLDB.
Changed prior to commit:
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Looks good!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86389/new/
https://reviews.llvm.org/D86389
___
lldb-commits mailing
JDevlieghere updated this revision to Diff 287164.
JDevlieghere added a comment.
- Add test.
- Implement dump method.
Unfortunately, the yaml2obj roundtrip does not preserve the UUID, so the test
uses the binary.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86389/new/
JDevlieghere added a comment.
I wasn't sure how to test this but Jason told me I can set
`LLDB_APPLE_DSYMFORUUID_EXECUTABLE`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86389/new/
https://reviews.llvm.org/D86389
___
lldb-commits mailing
JDevlieghere created this revision.
JDevlieghere added a reviewer: jasonmolenda.
Herald added a subscriber: mgrang.
JDevlieghere requested review of this revision.
When replaying a reproducer captured from a core file, we always use
dsymForUUID for the kernel binary. When enabled, we also use it
