[Lldb-commits] [PATCH] D86616: [cmake] Make gtest include directories a part of the library interface

ldionne added a comment. In D86616#2241936 , @labath wrote: > In D86616#2238946 , @ldionne wrote: > >> LGTM, but I'm not an owner for any of the projects touched by this change. > > I picked you because you seemed

[Lldb-commits] [PATCH] D86616: [cmake] Make gtest include directories a part of the library interface

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cb222e749e8: [cmake] Make gtest include directories a part of the library interface (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86616: [cmake] Make gtest include directories a part of the library interface

labath added a comment. In D86616#2238946 , @ldionne wrote: > LGTM, but I'm not an owner for any of the projects touched by this change. I picked you because you seemed interested in the overall direction that our cmake support is going :), and I

[Lldb-commits] [PATCH] D86616: [cmake] Make gtest include directories a part of the library interface

sivachandra accepted this revision. sivachandra added a comment. Libc change LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86616/new/ https://reviews.llvm.org/D86616 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D86616: [cmake] Make gtest include directories a part of the library interface

teemperor accepted this revision. teemperor added a comment. LGTM too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86616/new/ https://reviews.llvm.org/D86616 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D86616: [cmake] Make gtest include directories a part of the library interface

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM, but I'm not an owner for any of the projects touched by this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86616/new/

[Lldb-commits] [PATCH] D86616: [cmake] Make gtest include directories a part of the library interface

labath created this revision. labath added reviewers: ldionne, beanz. Herald added subscribers: libc-commits, lldb-commits, dexonsmith, hiraditya, mgorny. Herald added a reviewer: bollu. Herald added a reviewer: DavidTruby. Herald added projects: LLDB, libc-project, LLVM. labath requested review