[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55dd731b291c: [debugserver] Extract function for default launch flavor (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

teemperor added a comment. In D87327#2263971 , @kastiglione wrote: > @teemperor I'm not sure what these build errors mean, for example > https://reviews.llvm.org/B70998. Also there's the linux build failure, but > that's not relevant for debugserver,

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione added a comment. @teemperor I'm not sure what these build errors mean, for example https://reviews.llvm.org/B70998. Also there's the linux build failure, but that's not relevant for debugserver, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup! (And also having the second list of comments no longer always stating 'SpringBoard' is even better). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione updated this revision to Diff 290581. kastiglione added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87327/new/ https://reviews.llvm.org/D87327 Files: lldb/tools/debugserver/source/debugserver.cpp Index:

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione added a comment. Follow up to 8aeb212887024a615ca02437cd12fa055bd54b6f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87327/new/ https://reviews.llvm.org/D87327

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione created this revision. kastiglione added reviewers: jasonmolenda, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Extract a function for turning