[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

2020-09-10 Thread Valentin Clement via Phabricator via lldb-commits
clementval updated this revision to Diff 290770. clementval added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87389/new/

[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

2020-09-09 Thread Sourabh Singh Tomar via Phabricator via lldb-commits
SouraVX added a comment. Since `bbc` based test can't be added here, would you mind adding a unit-test here ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87389/new/ https://reviews.llvm.org/D87389

[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

2020-09-09 Thread Valentin Clement via Phabricator via lldb-commits
clementval added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:41 focus_tid(LLDB_INVALID_THREAD_ID), sent_terminated_event(false), - stop_at_entry(false), is_attach(false), - reverse_request_seq(0), waiting_for_run_in_terminal(false) { +

[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

2020-09-09 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:41 focus_tid(LLDB_INVALID_THREAD_ID), sent_terminated_event(false), - stop_at_entry(false),