This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4da8fa45a096: [lldb/API] Add
Breakpoint::SerializeToStructuredData to SBAPI (authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: JDevlieghere.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87491/new/
https://reviews.llvm.org/D87491
JDevlieghere added a comment.
The reproducer instrumentation part LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87491/new/
https://reviews.llvm.org/D87491
___
lldb-commits mailing list
lldb-commits
DavidSpickett added a comment.
This LGTM but I don't know the API standards very well. Some else should give a
final review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87491/new/
https://reviews.llvm.org/D87491
mib marked an inline comment as done.
mib added inline comments.
Comment at:
lldb/test/API/functionalities/breakpoint/serialize/TestBreakpointSerialization.py:77
+
self.assertEqual(serialized_data["Breakpoint"]["BKPTResolver"]["Options"]["FileName"],
"foo")
+
se
mib updated this revision to Diff 291209.
mib added a comment.
Add invalid breakpoint test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87491/new/
https://reviews.llvm.org/D87491
Files:
lldb/bindings/interface/SBBreakpoint.i
lldb/includ
DavidSpickett added inline comments.
Comment at:
lldb/test/API/functionalities/breakpoint/serialize/TestBreakpointSerialization.py:77
+
self.assertEqual(serialized_data["Breakpoint"]["BKPTResolver"]["Options"]["FileName"],
"foo")
+
self.assertEqual(serialized_da
mib created this revision.
mib added reviewers: jingham, kastiglione, teemperor.
mib added a project: LLDB.
Herald added subscribers: lldb-commits, JDevlieghere.
mib requested review of this revision.
This patch adds a way to get fetch breakpoint metadatas as a serialized
Structured Data (JSON). T
