[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

2020-09-27 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. This also doesn't work on my macOS system: FAIL: LLDB (/Users/teemperor/1llvm/rel/bin/clang-x86_64) :: test_stop_hooks_scripted_return_false (TestStopHookScripted.TestStopHooks) == FAIL:

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

2020-09-27 Thread David Zarzycki via Phabricator via lldb-commits
davezarzycki added a comment. Hi Jim, this change broke my Fedora 33 Linux (x86) box. Do you think we can get a quick fix or revert this? FAIL: lldb-shell :: Commands/command-stop-hook-output.test (69796 of 70913) TEST 'lldb-shell ::

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

2020-09-25 Thread Jim Ingham via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jingham marked 5 inline comments as done. Closed by commit rGb65966cff65b: Add the ability to write target stop-hooks using the ScriptInterpreter. (authored by

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

2020-09-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:302 + virtual StructuredData::GenericSP + CreateScriptedStopHook(lldb::TargetSP target_sp,

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

2020-09-23 Thread Jim Ingham via Phabricator via lldb-commits
jingham marked 9 inline comments as done. jingham added a comment. Addressed review comments. Comment at: lldb/docs/use/python-reference.rst:843 +|| | **target** is the SBTarget to which the stop hook is added.

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

2020-09-23 Thread Jim Ingham via Phabricator via lldb-commits
jingham updated this revision to Diff 293902. jingham marked 3 inline comments as done. jingham added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88123/new/ https://reviews.llvm.org/D88123 Files:

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

2020-09-23 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. I'm very excited about this feature. Great job on the documentation, both in the help output as for the website. Do you have a potential use case in mind that we could add to the examples? Comment at: lldb/docs/use/python-reference.rst:843 +|

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

2020-09-22 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4625 + +def__init__(self, target, extra_args, dict): + missing space after `def` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

2020-09-22 Thread Jim Ingham via Phabricator via lldb-commits
jingham updated this revision to Diff 293603. jingham added a comment. Added docs to the python-reference.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88123/new/ https://reviews.llvm.org/D88123 Files:

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

2020-09-22 Thread Jim Ingham via Phabricator via lldb-commits
jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, dang. Herald added a project: LLDB. jingham requested review of this revision. Previously, you could only have a list of command-line commands as the reaction to a stop hook. This