[Lldb-commits] [PATCH] D88581: [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds

2021-01-29 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Gentoo uses plain `/usr/lib/clang/X.Y.Z` which doesn't really match any of the tested paths. Do you think there's a point in adding yet another case there or should I just override it locally? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88581: [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds

2020-11-02 Thread Marko Novakovic via Phabricator via lldb-commits
mnovakovic added inline comments. Comment at: lldb/source/API/CMakeLists.txt:210 + if(NOT LLDB_BUILD_FRAMEWORK) +set(LLDB_CLANG_RESOURCE_DIR_PARENT "$/clang") +file(MAKE_DIRECTORY "${LLDB_CLANG_RESOURCE_DIR_PARENT}") mnovakovic wrote: > mnovakovic

[Lldb-commits] [PATCH] D88581: [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds

2020-11-02 Thread Marko Novakovic via Phabricator via lldb-commits
mnovakovic added inline comments. Comment at: lldb/source/API/CMakeLists.txt:210 + if(NOT LLDB_BUILD_FRAMEWORK) +set(LLDB_CLANG_RESOURCE_DIR_PARENT "$/clang") +file(MAKE_DIRECTORY "${LLDB_CLANG_RESOURCE_DIR_PARENT}") mnovakovic wrote: > JDevlieghere

[Lldb-commits] [PATCH] D88581: [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds

2020-11-02 Thread Marko Novakovic via Phabricator via lldb-commits
mnovakovic added inline comments. Comment at: lldb/source/API/CMakeLists.txt:210 + if(NOT LLDB_BUILD_FRAMEWORK) +set(LLDB_CLANG_RESOURCE_DIR_PARENT "$/clang") +file(MAKE_DIRECTORY "${LLDB_CLANG_RESOURCE_DIR_PARENT}") JDevlieghere wrote: > Can you check

[Lldb-commits] [PATCH] D88581: [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds

2020-10-06 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGce4d15fe142e: [lldb] Symlink the Clang resource directory to the LLDB build directory in… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG