[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

shafik added a comment. I am happy this was not hiding any regressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

This revision was automatically updated to reflect the committed changes. Closed by commit rG010d7a388b14: [lldb/test] Catch invalid calls to expect() (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione updated this revision to Diff 296217. kastiglione added a comment. "missing a matcher" -> "missing a matcher argument" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 Files:

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione added inline comments. Comment at: lldb/test/API/types/TestRecursiveTypes.py:54 +self.expect("print tpi") +self.expect("print *tpi") aprantl wrote: > I'm not not sure I understand this change? The second parameter, `msg`, is only

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2440-2441 +assert "patterns must be a collection of strings" and False +if isinstance(substrs, six.string_types): +assert "substrs must be a collection

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione updated this revision to Diff 296215. kastiglione added a comment. Resyntax the isinstance asserts; Add expect() tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 Files:

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

aprantl added inline comments. Comment at: lldb/test/API/types/TestRecursiveTypes.py:54 +self.expect("print tpi") +self.expect("print *tpi") I'm not not sure I understand this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

aprantl added a comment. Oh wow — that paid off! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

DavidSpickett added a comment. Does it make sense to add a few tests for this to `lldb/test/API/assert_messages_test/TestAssertMessages.py`? (this is only checking expect() messages, despite the generic name) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks for fixing all of this! Beside the assertion this LGTM. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2440-2441 +assert "patterns must

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2440-2441 +assert "patterns must be a collection of strings" and False +if isinstance(substrs, six.string_types): +assert "substrs must be a collection of

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, teemperor. Herald added subscribers: lldb-commits, kbarton, nemanjai. Herald added a project: LLDB. kastiglione requested review of this revision. Add preconditions to `TestBase.expect()` that catch