[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a600266c3ad: [lldb] Initial version of FreeBSD remote process plugin (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:82 void ProcessFreeBSD::Initialize() { - static llvm::once_flag g_once_flag; + if (!getenv("FREEBSD_REMOTE_PLUGIN")) { +static llvm::once_flag g_once_flag; lab

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

labath added inline comments. Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:269-375 + Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_PLATFORM)); + LLDB_LOG(log, "target {0}", target); + + // If we're a remote host, use standard behavior from parent class.

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny updated this revision to Diff 296439. mgorny added a comment. Removed now-redundant DebugProcess. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88796/new/ https://reviews.llvm.org/D88796 Files: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp lldb/source/Plugins/Plat

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny updated this revision to Diff 296238. mgorny marked 2 inline comments as done. mgorny added a comment. For a start, removed leftover printf and len increment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88796/new/ https://reviews.llvm.org/D88796 Files: lldb/source/Plugins/Pl

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

krytarowski added inline comments. Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:269-375 + Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_PLATFORM)); + LLDB_LOG(log, "target {0}", target); + + // If we're a remote host, use standard behavior from parent c

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

labath added a comment. BTW, are you running the lldb-server test suite on this? How's it shaping up? In D88796#2311594 , @mgorny wrote: > Also a potentially interesting concept would be to unify reg constants > between platforms. Which constants do you

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny added a comment. Also a potentially interesting concept would be to unify reg constants between platforms. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88796/new/ https://reviews.llvm.org/D88796 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny marked an inline comment as done. mgorny added a comment. Indeed I've been wondering how we could dedupe this. At least large part of hw watchpoint handling should be reusable. Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:274 + if (!IsHost()) {

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

labath added a comment. Looks pretty straigh-forward. I'm getting a lot of deja-vu when looking at this code, though it's not clear to me whether its identical of just similar. Have you investigated the possibility of factoring some parts of this && the netbsd code (and maybe linux too) into so

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny marked 5 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:492 + } + for (i = 0; i < count; i++) { +MemoryRegionInfo info; arichardson wrote: > This code is C++ so u

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny updated this revision to Diff 296059. mgorny added a comment. Inlined memory map getting via sysctl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88796/new/ https://reviews.llvm.org/D88796 Files: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp lldb/source/Plugins/P

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

arichardson added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:492 + } + for (i = 0; i < count; i++) { +MemoryRegionInfo info; This code is C++ so using for-loop initializers is fine. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:22 + +//#include "Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD.h" +#include "Plugins/Process/POSIX/ProcessPOSIXLog.h" mgorny wrote: >

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:22 + +//#include "Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD.h" +#include "Plugins/Process/POSIX/ProcessPOSIXLog.h" krytarowski wrote: >

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny updated this revision to Diff 296051. mgorny added a comment. Cleaned up unused includes + clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88796/new/ https://reviews.llvm.org/D88796 Files: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp lldb/source/Plugi

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:22 + +//#include "Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD.h" +#include "Plugins/Process/POSIX/ProcessPOSIXLog.h" Why this line?

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny created this revision. mgorny added reviewers: emaste, krytarowski, labath. Herald added a subscriber: arichardson. mgorny requested review of this revision. Add a new FreeBSD Process plugin using client/server model. This plugin is based on the one used by NetBSD. It currently supports a