This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd30797b4041f: [lldb] Minidump: check for .text hash match
with directory (authored by JosephTremoulet).
Repository:
rG LLVM Github Monorepo
CHANG
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, I was out of town until today. Changes look good! Always
good to have more robust support for finding binaries in the sysroot.
Repository:
rG LLVM Github Monorepo
JosephTremoulet marked an inline comment as done.
JosephTremoulet added a comment.
Thanks for the speedy review! I've updated it to include a testcase that shows
the problem you described, and include the fix you suggested.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
JosephTremoulet updated this revision to Diff 297422.
JosephTremoulet added a comment.
- Handle finding wrong version before right one
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89155/new/
https://reviews.llvm.org/D89155
Files:
lldb/source/Pl
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:533
+ }
if (module_sp) {
// We consider the module to be a match i
JosephTremoulet created this revision.
Herald added a reviewer: JDevlieghere.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
JosephTremoulet requested review of this revision.
When opening a minidump, we might discover that it reports a UUID for a
module that doesn't match
