[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione added a comment. Thanks for pointing this in the right direction @labath, @teemperor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 ___ lldb-commits

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

labath added a comment. Yes, runCmd is the way to go here... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione added a comment. That's much better. I'll change those callers can be changed to `runCmd`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 ___ lldb-co

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

teemperor added a comment. In D91193#2386832 , @kastiglione wrote: > @teemperor maybe? Do you mean validation should go in `runCmd`? Or do you > mean something else? I meant that to my knowledge command execution where the only expectation is that they

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione added a comment. @teemperor maybe? Do you mean validation should go in `runCmd`? Or do you mean something else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 _

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

teemperor added a comment. Isn't that what we use `runCmd` for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione created this revision. kastiglione added reviewers: jingham, teemperor, aprantl, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Restore ability to call `expect()` with a message and no matcher. After