[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

jankratochvil added a comment. Checked in a regression fix: rG18a85276426b9604a9ceca8c528b694964dd8d7c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sounds good. Lets gets this in then and start iterating on future patches! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace added a comment. I like that idea, but i'd rather do it in a different patch once we have a second stop event, so that I make sure the entire thing makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg added a comment. Looking really good. See inline comments about the need for a ProcessorTraceStopReason. Since we have the eStopReasonProcessorTrace stop reason now, we should probably deliver these stops to the Trace plug-in so that it can respond maybe? Fine if we can to do this in

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/docs/lldb-gdb-remote.txt:246-251 +// { +// "name": , +// Tracing technology name, e.g. intel-pt, arm-coresight. +//

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace reclaimed this revision. wallace added a comment. Changed my mind :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/ https://reviews.llvm.org/D91679 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace abandoned this revision. wallace marked 7 inline comments as done. wallace added a comment. I'll redo this diff in smaller diffs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/ https://reviews.llvm.org/D91679

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg added a comment. See my inlined comments, but it would be great to be able to just trace a few threads if any "tids" are specified in the "jLLDBTraceStart" packet, and all threads using a per thread buffer and call that "process". We would still use a per thread buffer for "process"

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:278 +// "tids": [], +// "variant": "specificThreads" | "currentAndFutureThreads" | "process", +// "params": { clayborg wrote: > Seems like we don't need the "variant" here. If

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg added a comment. > The start and stop operations have 3 variants for now: > > - specificThreads: operate on specific threads (e.g. thread trace start 2 3 9) > - currentAndFutureThreads: operate of all threads including future ones (e.g. > thread trace start all) > - process: operate

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So I think I get the gist of what you were trying to go for with this patch. I stopped inline comments after I got the idea. A few things: We need to be able to enable tracing

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace created this revision. wallace added a reviewer: clayborg. Herald added subscribers: lldb-commits, dang. Herald added a project: LLDB. wallace requested review of this revision. Herald added a subscriber: JDevlieghere. This implements the interactive trace start and stop methods. There's