DavidSpickett created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
DavidSpickett requested review of this revision.
Herald added a subscriber: JDevlieghere.
Previously we used UINT16_MAX to mean no port/no specifc
port. This leads to confusion because 65535
DavidSpickett added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:197
#endif
- uint16_t *port_ptr = &port;
+ uint16_t *port_ptr = port.getPointer();
if (m_socket_protocol == Socket::ProtocolTcp) {
-
labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:197
#endif
- uint16_t *port_ptr = &port;
+ uint16_t *port_ptr = port.getPo
DavidSpickett updated this revision to Diff 307824.
DavidSpickett added a comment.
- Reformat GDBRemoteCommunicationServerPlatform.h to fix include order.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92035/new/
https://reviews.llvm.org/D92035
Fil
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa7f8d96b16a3: [lldb] Use llvm::Optional for port in
LaunchGDBServer (authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
