[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

2021-01-05 Thread Balázs Kéri via Phabricator via lldb-commits
balazske added a comment. The problem is reproduced and fixed in D94067 . It is caused by import of default template arguments indirectly, because that import causes lot of other things to be imported. And the import of default arguments happens in a incomplete

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

2020-12-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D92103#2428139 , @martong wrote: > Hey Raphael, thanks for looking into the CTU crash! > > I also had a look and I could reproduce that on Linux Ubuntu 18.04 with GCC > 7. I think the discrepancy stems from GCC's libstdc++

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

2020-12-02 Thread Gabor Marton via Phabricator via lldb-commits
martong added a subscriber: balazske. martong added a comment. Hey Raphael, thanks for looking into the CTU crash! I also had a look and I could reproduce that on Linux Ubuntu 18.04 with GCC 7. I think the discrepancy stems from GCC's libstdc++ and MacOS's libc++ implementation differences of

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

2020-12-01 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. @gamesh411 I recreated the setup you listed (thanks for that btw) but for me this works just fine. I assume the crash happens in a class template from one of the external libraries. It probably works for me because I don't have the same library version as you have,

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

2020-11-30 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added inline comments. Comment at: lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py:25 -deque_type = "std::deque >" size_type = deque_type + "::size_type" Why do the default arguments not show

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

2020-11-28 Thread Endre Fülöp via Phabricator via lldb-commits
gamesh411 added a comment. On bitcoin v0.18.1 , there is an assertion introduced by this change. The TU that can be used for reproduction is `src/script/interpreter.cpp`. Assertion message: CTU loaded AST file:

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

2020-11-26 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3f6c856bb5ae: [ASTImporter] Import the default argument of TemplateTypeParmDecl (authored by teemperor). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed

[Lldb-commits] [PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

2020-11-26 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added inline comments. Herald added a subscriber: JDevlieghere. Comment at: clang/lib/AST/ASTImporter.cpp:5161 - // FIXME: Import default argument and constraint expression. + // FIXME: Import constraint expression. martong wrote: > I wonder