[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. The considered .debug_names index update would need to make .debug_names working in the first place - as it does not work now: D99850 So maybe the manual DIE traversal without updating the index and without the regex capability is

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. I think you should remove: `lldb/test/API/.lit_test_times.txt` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92223/new/ https://reviews.llvm.org/D92223 ___ lldb-commits mai

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. Based on https://reviews.llvm.org/D92643#inline-925368 where the DIE traversal cannot performance-reasonably implement `target variable -r` I am returning here whether the `.debug_names` index could not be rather extended/improved. LLDB would fall back to `ManualD

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat added a comment. In D92223#2546736 , @jankratochvil wrote: > This patch may be superseded by D92643 , not > sure. Yeah, D92643 is an alternative way to implement this, according t

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. This patch may be superseded by D92643 , not sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92223/new/ https://reviews.llvm.org/D92223 __

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3181 + if (tag == DW_TAG_member && !const_value_form.IsValid()) { +// Allows only members with DW_AT_const_value attribute, i.e. static const This is a nitpi

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. FYI it would not work with GNU C++ 4.4 (2008, RHEL-5) as it used `DW_TAG_variable` instead of `DW_TAG_member`. But that is probably not a problem, Red Hat's last supported RHEL for new toolchains is since RHEL-6 and for LLVM even just since RHEL-7: <0>: Abbrev

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. In D92223#2422184 , @labath wrote: > I am not sure if this is the right way to implement this feature. Changing > ManualDWARFIndex to provide this additional information is easy enough, but > it means that the other index c

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat added a comment. Pavel, thanks for review! In D92223#2422184 , @labath wrote: > I am not sure if this is the right way to implement this feature. Changing > ManualDWARFIndex to provide this additional information is easy enough, but > it means tha

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

labath added a comment. I am not sure if this is the right way to implement this feature. Changing ManualDWARFIndex to provide this additional information is easy enough, but it means that the other index classes will never be able to support this functionality (without, essentially, reimplemen

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat updated this revision to Diff 308053. werat added a comment. Remove unused field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92223/new/ https://reviews.llvm.org/D92223 Files: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp ll

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat updated this revision to Diff 308052. werat added a comment. Simplified test according to teemperor's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92223/new/ https://reviews.llvm.org/D92223 Files: lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat added reviewers: jarin, aprantl, shafik. werat added a comment. Hi, please, take a look at this patch. It seems Pavel already did some work for class-level static const variables in https://reviews.llvm.org/D86615, although that didn't work the case I've encountered. In my example (which

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

teemperor added reviewers: labath, jankratochvil. teemperor added a comment. Not sure who's the right person to review the SymbolFileDWARF.cpp/ManualDWARFIndex.cpp, but Pavel/Jan touched that not too long ago. (D81471 might also be an interested patch for you.

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

werat created this revision. Herald added subscribers: lldb-commits, arphaman. Herald added a project: LLDB. werat requested review of this revision. Herald added a subscriber: JDevlieghere. Static const/constexpr members might have only DW_TAG_member entry with a DW_AT_const_value attribute. Sinc