[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

2021-01-20 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandOptionsProcessLaunch.h:1 +//===-- CommandOptionsProcessLaunch.h -===// +// Nit: header files should have the `-*- C++ -*-===//` at the

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

2021-01-20 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib closed this revision. mib added a comment. Landed in 7169d3a315f4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95059/new/ https://reviews.llvm.org/D95059

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

2021-01-20 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 317914. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95059/new/ https://reviews.llvm.org/D95059 Files: lldb/include/lldb/Target/Process.h lldb/source/Commands/CMakeLists.txt

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

2021-01-20 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95059/new/ https://reviews.llvm.org/D95059

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

2021-01-20 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 317911. mib added a comment. Add header guards and split tablegen long description into multiple lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95059/new/ https://reviews.llvm.org/D95059 Files:

[Lldb-commits] [PATCH] D95059: [lldb/Commands] Refactor ProcessLaunchCommandOptions to use TableGen (NFC)

2021-01-20 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added a reviewer: teemperor. Herald added subscribers: dang, mgorny. mib requested review of this revision. Herald added a project: LLDB. This patch refactors the current implementation of `ProcessLaunchCommandOptions` to be generated by TableGen. The patch also