[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG619e2e095fb1: [lldb] Convert assertTrue(a == b) to assertEqual(a, b) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

kastiglione updated this revision to Diff 320878. kastiglione added a comment. assertNotEqual & formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95813/new/ https://reviews.llvm.org/D95813 Files:

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

teemperor accepted this revision. teemperor added a comment. Don't see any change that looks wrong from scrolling over this, so LGTM Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/atomic/TestLibCxxAtomic.py:59 -

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

teemperor added a comment. In D95813#2535209 , @JDevlieghere wrote: > Cool, I was under the impression @teemperor had already done something > similar, but I must be misremembering. I ran one big regex that got most of the Equal/Less/Bigger than, but I

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

kastiglione added inline comments. Comment at: lldb/test/API/python_api/frame/TestFrames.py:97 sp_value, "We should have a valid Stack Pointer.") -self.assertTrue(int(sp_value.GetValue(), 0) == frame.GetSP( +

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Cool, I was under the impression @teemperor had already done something similar, but I must be misremembering. Comment at:

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

kastiglione added a comment. I haven't run tests yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95813/new/ https://reviews.llvm.org/D95813 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D95813: [lldb] Convert assertTrue(a == b) to assertEqual(a, b)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Convert `assertTrue(a == b)` to `assertEqual(a, b)` to produce better failure messages.