[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 created this revision. augusto2112 added reviewers: labath, clayborg, jasonmolenda. Herald added a subscriber: dang. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. jAttachWait provides the same functionality as vAtt

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 added a comment. Herald added a subscriber: JDevlieghere. As discussed in the vAttachWait patch (https://reviews.llvm.org/D93895), I've implemented a jAttachWait packet with supports two additional parameters (polling interval and polling duration) when attaching to a process by name

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

clayborg added a comment. See inlined comment about the packet name issue and let me know what you think Comment at: lldb/include/lldb/Target/Process.h:182-183 m_wait_for_launch = false; +m_wait_for_launch_interval = llvm::Optional(); +m_wait_for_launch_duration =

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

labath added a comment. I'm not sure this new functionality is really worth the new packet (or two), but if it solves a use case you care about, then I suppose that's fine. One alternative could be to just tack on some extra data to the existing vAttach family packets (`vAttachWait;foo;interva

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 added a comment. In D96176#2546777 , @labath wrote: > One alternative could be to just tack on some extra data to the existing > vAttach family packets (`vAttachWait;foo;interval:47;duration=74`). This was how I did it originally on https://

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

labath added a comment. In D96176#2547324 , @augusto2112 wrote: > In D96176#2546777 , @labath wrote: > >> One alternative could be to just tack on some extra data to the existing >> vAttach family packets (`vAttac

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 updated this revision to Diff 329385. augusto2112 marked 7 inline comments as done and an inline comment as not done. augusto2112 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96176/new/ https://reviews

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 added a comment. In D96176#2546777 , @labath wrote: > I'm not sure this new functionality is really worth the new packet (or two), > but if it solves a use case you care about, then I suppose that's fine. To be honest, I started this as I tho